Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

ONNX ops: norm exported and lpnormalization imported #13806

Merged
merged 6 commits into from
Jan 10, 2019
Merged

ONNX ops: norm exported and lpnormalization imported #13806

merged 6 commits into from
Jan 10, 2019

Conversation

Roshrini
Copy link
Member

@Roshrini Roshrini commented Jan 9, 2019

Description

Exported norm operator and imported lpnormalization.
Test cases added
@vandanavk

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@Roshrini Roshrini requested a review from szha as a code owner January 9, 2019 01:04
vandanavk
vandanavk reviewed Jan 9, 2019
View reviewed changes
Copy link
Contributor

@vandanavk vandanavk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just a few minor comments

python/mxnet/contrib/onnx/mx2onnx/_op_translations.py Outdated Show resolved Hide resolved
python/mxnet/contrib/onnx/onnx2mx/_op_translations.py Show resolved Hide resolved
python/mxnet/contrib/onnx/mx2onnx/_op_translations.py Outdated Show resolved Hide resolved
python/mxnet/contrib/onnx/mx2onnx/_op_translations.py Outdated Show resolved Hide resolved
@Roshrini
Copy link
Member Author

Roshrini commented Jan 9, 2019

@mxnet-label-bot Add [ONNX, pr-awaiting-review]

@marcoabreu marcoabreu added ONNX pr-awaiting-review PR is waiting for code review labels Jan 9, 2019
@Roshrini
Copy link
Member Author

Roshrini commented Jan 9, 2019

@zhreshold Can you please review this PR?

zhreshold
zhreshold approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@zhreshold zhreshold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Roshrini Roshrini merged commit bc39183 into apache:master Jan 10, 2019
@Roshrini Roshrini deleted the lpnorm-op branch January 10, 2019 03:46
zhaoyao73 added a commit to zhaoyao73/incubator-mxnet that referenced this pull request Jan 11, 2019
@zhaoyao73
Merge remote-tracking branch 'upstream/master'
7c21b53 
* upstream/master: (109 commits)
  Code modification for  testcases of various network models in directory example (apache#12498)
  [CI] Prevent timeouts when rebuilding containers with docker. (apache#13818)
  fix Makefile for rpkg (apache#13590)
  change to compile time (apache#13835)
  Disabled flaky test (apache#13758)
  Improve license_header tool by only traversing files under revision c… (apache#13803)
  Removes unneeded nvidia driver ppa installation (apache#13814)
  Add Local test stage and option to jump directly to menu item from commandline (apache#13809)
  Remove MXNET_STORAGE_FALLBACK_LOG_VERBOSE from test_autograd.py (apache#13830)
  Fix scala doc build break for v1.3.1 (apache#13820)
  [MXNET-1263] Unit Tests for Java Predictor and Object Detector APIs (apache#13794)
  [MXNET-1260] Float64 DType computation support in Scala/Java (apache#13678)
  onnx export ops (apache#13821)
  [MXNET-880] ONNX export: Random uniform, Random normal, MaxRoiPool (apache#13676)
  fix minor indentation (apache#13827)
  Fixing a symlink issue with R install (apache#13708)
  remove useless code (apache#13777)
  ONNX ops: norm exported and lpnormalization imported (apache#13806)
  Add new Maven build for Scala package (apache#13819)
  Dockerfiles for Publish Testing (apache#13707)
  ...
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@Roshrini
ONNX ops: norm exported and lpnormalization imported (apache#13806)
3f8238f 
* ReduceL1, l2 export, lpnormalization import added

* fix

* fix

* fix

* fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhreshold zhreshold zhreshold approved these changes

@vandanavk vandanavk vandanavk approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Roshrini @zhreshold @vandanavk @marcoabreu