[FLINK-7580] Automatically retry failed gateway retrievals #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
retryingLeaderGatewayRetrieverImpl
branch
2 times, most recently
from
1c90ddc
to
36df55a
Compare
Introduce a generalized GatewayRetriever replacing the JobManagerRetriever. The GatewayRetriever fulfills the same purpose as the JobManagerRetriever with the ability to retrieve the gateway for an arbitrary endpoint type. This closes apache#4549.
Introduce RedirectHandler which can be extended to add redirection functionality to all SimpleInboundChannelHandlers. This allows to share the same functionality across the StaticFileServerHandler and the RuntimeMonitorHandlerBase which could now be removed. In the future, the AbstractRestHandler will also extend the RedirectHandler. This closes apache#4551.
Add test case Only log LeaderGatewayRetriever exception on Debug log level Properly fail outdated gateway retrieval operations This closes apache#4602.
The LeaderGatewayRetriever implementations, AkkaJobManagerRetriever and the RpcGatewayRetriever, now automatically retry the gateway retrieval operation for a fixed number of times with a retry delay before completing the gateway future with an exception. Retry AkkaJobManagerRetriever Retry RpcGatewayRetriever This closes apache#4643.
tillrohrmann
force-pushed
the
retryingLeaderGatewayRetrieverImpl
branch
from
36df55a
to
80cfebb
Compare
|
@tillrohrmann No, I haven't looked at #4602 yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The LeaderGatewayRetriever implementations, AkkaJobManagerRetriever and the RpcGatewayRetriever, now automatically retry the gateway retrieval operation for a fixed number of times with a retry delay before completing the gateway future with an exception.
Verifying this change
This change is already covered by existing tests, such as
FutureUtilsTest(retryWithDelaytests).Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation