[FLINK-7459] Generalize Flink's redirection logic #4551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a4a680
to
ce15a48
Compare
ce15a48
to
9f92480
Compare
Introduce a generalized GatewayRetriever replacing the JobManagerRetriever. The GatewayRetriever fulfills the same purpose as the JobManagerRetriever with the ability to retrieve the gateway for an arbitrary endpoint type. This closes apache#4549.
|
Rebasing onto the latest master. |
Introduce RedirectHandler which can be extended to add redirection functionality to all SimpleInboundChannelHandlers. This allows to share the same functionality across the StaticFileServerHandler and the RuntimeMonitorHandlerBase which could now be removed. In the future, the AbstractRestHandler will also extend the RedirectHandler. This closes apache#4551.
9f92480
to
41dba8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Introduce RedirectHandler which can be extended to add redirection functionality to all
SimpleInboundChannelHandlers. This allows to share the same functionality across the
StaticFileServerHandler and the RuntimeMonitorHandlerBase which could now be removed.
In the future, the AbstractRestHandler will also extend the RedirectHandler.
This PR is based on #4549.
Brief change log
RedirectHandlerwhich encapsulates the redirection logicStaticFileServerHandlerandRuntimeMonitorHandlerextend theRedirectHandlerVerifying this change
This change added tests and can be verified as follows:
RedirectHandlerTestwhich tests the redirection logicDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation