[FLINK-1086] Replaced jcl with slf4j and log4j with logback. #111
Conversation
Excluded kafkas transitive dependencies: jmxtools and jmxri. Corrected encoder pattern in logback.xml Removed explicit logging access. Loggers are now configured by configuration files. Fixed Yarn issue with multiple logging bindings.
|
Very nice. I will have a look later, but would already vote to add the small notes from your mailing list thread [1] to the docs and make it part of the PR. |
|
Good point Ufuk. I'll add the information to the docs. |
|
I added the documentation. |
| @@ -43,6 +42,8 @@ The Apache Flink project depends on and/or bundles the following components | |||
| under the Eclipse Public License (v 1.0) | |||
|
|
|||
| - JUnit (https://junit.org/) | |||
| - logback (https://logback.qos.ch) | |||
| Copyright (C) 1999-2012, QOS.ch. All rights reserved. | |||
There was a problem hiding this comment.
Nice that you didn't forget to update this 👍
I'm not sure if the Copyright line is necessary, because you have it in the lower section. And for the name, I think we should have it as LOGBack.
There was a problem hiding this comment.
I'm not sure either. Maybe we should ask our License/Dependency guru @StephanEwen what's the right way to do it.
|
Thanks for adding the documentation. :-) I've checked the configuration files of the tests and bash scripts. I didn't check every single file, where you replaced the log4j logger though, but since everything is compiling and the tests are running, it should be fine (the test that is failing is unrelated to this PR, see FLINK-1077). +1 to merge. I like the new logging pattern, which now includes the thread: |
|
I'm merging this now. |
Replaced the jcl logging interface with slf4j and log4j with logback. Removed also log4j specific code so Flink can easily be executed using a different slf4j binding. This work also standardises the logging configuration which is now exclusively done by specifying a logback.xml configuration file. This file is either put in the classpath (e.g. src/main/resources/) or given via the environment property -Dlogback.configurationFile. If no configuration is provided then the default configuration of logback is used.