Respect log4j.properties in LocalEnvironment #106
Conversation
…g all logging by default
| @@ -95,7 +95,9 @@ public boolean isLoggingEnabled() { | |||
| } | |||
|
|
|||
| private void initLogging() { | |||
| LogUtils.initializeDefaultConsoleLogger(logging ? Level.INFO : Level.OFF); | |||
| if(System.getProperty("log4j.properties") == null) { | |||
| LogUtils.initializeDefaultConsoleLogger(logging ? Level.INFO : Level.OFF); | |||
There was a problem hiding this comment.
Why not take the log level from the log4j.properties as well?
There was a problem hiding this comment.
I think that Log4J is reading the properties file if there is one (so it will automatically take the log level from it)
|
We should probably wait with this pull request until @tillrohrmann has finished the switch over to the new logging framework. |
|
This pull request should be obsolete once #111 has been merged. This pull request requires henceforth that the configuration of the logging framework is done by providing a configuration file. If the configuration file is not provided, then the default settings are used. Currently, logback is chosen as the slf4j binding and logback set the log level to DEBUG by default and prints everything on stdout. |
This closes apache#106.
...instead of just disabling all logging by default