Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mango): correct the fix for the duplicated text results #4801

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

pgj
Copy link
Contributor

@pgj pgj commented Oct 5, 2023

This is a follow-up to #4782. Commits d6d4ad9 and ce2607a missed out on the necessity of keeping the bookmark updated all the time. Otherwise the same hits might be returned which can lead to an infinite loop at the processing and make the integration test suite hang, for example.

This change is covered by the existing unit and integration tests.

Commits d6d4ad9 and ce2607a missed out on the necessity of
keeping the bookmark updated all the time.  Otherwise the same
hits might be returned which can lead to an infinite loop at the
processing and make the integration test suite hang, for example.
Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pgj pgj merged commit 93dfd4e into apache:main Oct 5, 2023
14 checks passed
@pgj pgj deleted the fix/mango/text-cursor-hangs branch October 5, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants