Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(mango): fix for duplicated text results #4800

Closed
wants to merge 2 commits into from
Closed

revert(mango): fix for duplicated text results #4800

wants to merge 2 commits into from

Conversation

pgj
Copy link
Contributor

@pgj pgj commented Oct 5, 2023

This PR is to remove the commits from #4782 about the fix itself. During the review a regression was introduced which went unnoticed until recently. It causes the Mango integration test suite hang and possibly breaks the integration of /{db}/_find with Clouseau.

@pgj
Revert "mango: prevent occasional duplication of paginated text res…
d94446b 
…ults"

This reverts commit d6d4ad9.  It makes the integration test
suite hang.
@pgj
Revert "mango: de-duplicate results on returning them in nouveau"
0d0c1a6 
This reverts commit ce2607a.  This was pair up with the fix to
the `text` cursor but it had problems in the meantime.
jiahuili430
jiahuili430 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@jiahuili430 jiahuili430 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed, +1

@pgj
Copy link
Contributor Author

pgj commented Oct 5, 2023

It has been superseded by #4801, so I am now closing this.

@pgj pgj closed this Oct 5, 2023
@pgj pgj deleted the revert/mango/duplicated-text-results branch October 5, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiahuili430 jiahuili430 jiahuili430 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pgj @jiahuili430