Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove js harness & tests #3197

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Remove js harness & tests #3197

merged 1 commit into from
Oct 7, 2020

Conversation

wohali
Copy link
Member

@wohali wohali commented Oct 6, 2020

Overview

This PR removes the JavaScript test suite, the test harness, and all support for the test harness and its options in couchjs.

It further removes references to libcurl from the build process and install documentation, as CouchDB no longer depends on it. In the process I also noticed we no longer require help2man, so that is also removed from the INSTALL readme.

Testing recommendations

make check should pass on all platforms.

Related Issues or Pull Requests

Possible because of #3192 and all the great work by @jjrodrig , @dottorblaster and many others for converting the suite to Elixir. Great work!

Checklist

  • Code is written and works correctly
  • Changes are covered by tests
  • Any new configurable parameters are documented in rel/overlay/etc/default.ini

Copy link
Member

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Bye bye, JS tests!

@dottorblaster
Copy link
Member

Wow. This is an amazing milestone, congratulations to us all! ❤️

Copy link
Contributor

@jjrodrig jjrodrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok for me.
I think that we can remove some Makefile targets but we can do it in a separate PR
I didn't imagine this impact! Congrats to all!

@wohali wohali force-pushed the remove-js-harness branch 2 times, most recently from b6702ef to d0c3854 Compare October 7, 2020 16:56
@wohali
Copy link
Member Author

wohali commented Oct 7, 2020

@jjrodrig OK, removed those targets too.

@wohali wohali merged commit 6b23f20 into main Oct 7, 2020
@wohali wohali deleted the remove-js-harness branch October 7, 2020 17:29
wohali added a commit that referenced this pull request Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants