Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for removing javascript tests from main build process #3192

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

jjrodrig
Copy link
Contributor

@jjrodrig jjrodrig commented Oct 5, 2020

Overview

All the active JS tests have been ported to elixr. The current make javascript execution is not performing any test.
I propose to remove it from the main build process.

This PR removes @$(MAKE) javascript from the check target

Testing recommendations

make check should not run the javascript test suite

Related Issues or Pull Requests

N/A

Checklist

@jjrodrig jjrodrig requested a review from wohali October 5, 2020 20:31
@wohali
Copy link
Member

wohali commented Oct 6, 2020

Hi @jjrodrig , this isn't sufficient to fully remove JS from our build process, but if you want to commit this and leave the rest to me, +1.

There's more in configure that needs to be dealt with, and certain things like our Windows builds will change. We will also no longer depend on libcurl which is an advantage in and of itself.

@wohali
Copy link
Member

wohali commented Oct 6, 2020

Also you probably want to target main instead of master, and don't forget 3.x.

@jjrodrig
Copy link
Contributor Author

jjrodrig commented Oct 6, 2020

Yes, more work is required to fully remove the JS support. But, as an initial step, we could just stop running javascript target during the build process.
I'll move all these commits to main and 3.x
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants