1523 bye bye 5986

[rnewson]

Overview

This PR enhances the _node endpoint in two ways;

1. The _system, _stats, and _restart endpoints on port 5984 which only affect the local node are now available under _node.
2. The full internal interface reachable on port 5986 is available under _node. This is achieved by sending the http response of the remote node over erlang rpc.

Testing recommendations

Try;

curl 'foo:bar@localhost:15984/_node/[email protected]/_stats'
curl 'foo:bar@localhost:15984/_node/[email protected]/_system'
curl 'foo:bar@localhost:15984/_node/[email protected]/_restart'
curl 'foo:bar@localhost:15984/_node/[email protected]/_all_dbs'
curl 'foo:bar@localhost:15984/_node/[email protected]/_uuids'
curl 'foo:bar@localhost:15984/_node/[email protected]/_config'
curl 'foo:bar@localhost:15984/_node/[email protected]/_nodes/_changes?include_docs=true

Related Issues or Pull Requests

#1523

Checklist

• Code is written and works correctly
• Changes are covered by tests
• Any new configurable parameters are documented in rel/overlay/etc/default.ini
• A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

[davisp]

Impressively clever. +1

The only thing I'm wondering though is whether we can't remove the _config/_stats/_restart specializations in chttpd_node.erl. Though I didn't look hard enough to see how different those implementations are from what's in the older couch_httpd_* handlers.

[willholley]

Thinking ahead to the 3.x release, Is there any documentation update needed to go with this?

It looks as though there is a new option under httpd.enabled - does that mean it's now possible to disable HTTP and enable HTTPS only?

Are we still maintaining the distinct [chttpd] and [httpd] config sections? Perhaps there's an opportunity to sanitize those for 3.x as the split seems a bit redundant if 5986 is gone.

[wohali]

@rnewson @willholley we need to remove couchup and the documentation for it per #2324 and this PR, unless couchup can be rewritten to work with the new _node interface soon enough - which it might be. But if we're going to say 1.x -> 3.x is forbidden, then we should just say that and drop couchup entirely.