Remove vestiges of view-based _changes feed from codebase
#2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocolosk
approved these changes
Nov 23, 2019
| @@ -1168,10 +965,10 @@ maybe_update_index_file(State) -> | |||
| end. | |||
|
|
|||
| update_index_file(State) -> | |||
There was a problem hiding this comment.
Suggest upgrading the logging here to notice level and including more details about the index file that we're attempting to update.
davisp
approved these changes
Dec 2, 2019
eiri
force-pushed
the
2167-no-view-changes
branch
from
50f68ca
to
e1c66f2
Compare
nickva
added a commit
that referenced
this pull request
Dec 11, 2019
The test broke during the removal of view-based changes PR Issue: #2324
davisp
pushed a commit
that referenced
this pull request
Dec 11, 2019
The test broke during the removal of view-based changes PR Issue: #2324
nickva
added a commit
that referenced
this pull request
Dec 11, 2019
The test broke during the removal of view-based changes PR Issue: #2324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes all bits and pieces of view_changes from mrview, couch_changes and fabric applications, removes
/_view_changesend-point and removes seq, kseq and log btrees from mrview file structure. Migration code for 1.2 views was modified to support transparent migration from 2.x views.Testing recommendations
All the tests should pass. Sinice this is removing functionality tests for which been disabled anyway, it's hard to validate it otherwise.
Additional manual testing could be done with creation of views on CouchDB 2.x with
seq_indexedand / orkeyseq_indexedoptions set and then accessing them on this CouchDB version. Here is a setup I've used for testing, it could help to get up to speed with that.Related Issues or Pull Requests
Closes #2167
Checklist
rel/overlay/etc/default.ini