2071 better create db ui #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e389a8b. This is the commit that broke modals. Reverting it fixes COUCHDB-2086 Fixing the right hand content overlapping the left hand navigation will require a bigger fix... This sadly was not it...
|
I'd like to squash these before merge |
|
@drsm79 got this tested and it generally looks good. However, if you navigate away using the hash in the URL, the modal goes away, but the modal-backdrop stays around. I'm digging for that, but if you want to take another look. Feel free. |
|
@drsm79 what is the status on this PR? Did it get merged in? |
|
It didn't - I've not had a chance to address the issue @BigBlueHat raised. That seems like a general issue - I was thinking of adding a listener for the route event to the modal base class. Sane? |
|
We now have a tray for DBs in Fauxton (apache/couchdb-fauxton@0592645) Can you can close the PR? |
nickva
pushed a commit
to cloudant/couchdb
that referenced
this pull request
Apr 21, 2017
This closes apache#155 Signed-off-by: ILYA Khlopotov <[email protected]>
lag-linaro
pushed a commit
to lag-linaro/couchdb
that referenced
this pull request
Oct 25, 2018
Fixes for apache#137 and apache#142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a modal for DB create, including validation of DB name.