1870 add language option to mapreduce editor #137

BigBlueHat · 2014-01-21T21:53:14Z

This should close the deceptively simple sounding COUCHDB-1870.

It includes a new ACE mode for CoffeeScript and all the surrounding ephemera.

Enjoy! 🍰

BigBlueHat · 2014-01-21T21:55:16Z

@garrensmith, @deathbearbrown for your reviewing entertainment. 🎉

kxepal · 2014-01-21T22:20:16Z

Hey @BigBlueHat ! That's awesome!

Small quick check from me:

File src/fauxton/assets/js/libs/ace/worker-coffee.js is lack of license header and missed in src/Makefile.am

File src/fauxton/assets/js/libs/ace/mode-coffee.jsis missed in src/Makefile.am, license.skip and NOTICE.

kxepal · 2014-01-21T22:26:59Z

Also, question to you and @garrensmith with @deathbearbrown. The good old Futon has also predefined templates for Python and Ruby languages. As for active user of Python query server I'd like to ask: will they be preserved in Fauxton?(: If templates there are only for query servers that are ships with CouchDB, may be also add template for Erlang views like:

fun({Doc}) ->
  Id = couch_util:get_value(<<"_id">>, Doc),
  Emit(Id, null)
end.

garrensmith · 2014-01-22T08:36:08Z

Hey @BigBlueHat,

Thanks for this. We are going to have to change the way we do this. We need to add this functionality as a plugin that is a seperate module that hooks in as an extensions. Not all couchdb instances that run Fauxton are capable of running different languages eg Pouchdb-server and Cloudant.

The other advantage of making this a module is that we could add full support for Ruby, Python and Erlang.

garrensmith · 2014-01-22T08:37:50Z

src/fauxton/app/addons/documents/views.js

 }
 },

 defaultLang: "javascript",

 initialize: function(options) {
+ var self = this;


we use that instead of self. It is a personal choice but for Fauxton we have stuck to the convention of that.

Noted, and will fix.

BigBlueHat · 2014-01-22T12:02:19Z

@kxepal handled the license.skip & src/Makefile.am bits. worker-javascript.js didn't have a license header either (they're both from https://github.com/ajaxorg/ace-builds/ fwiw). Those can be added, of course. Just let me know if they're needed (I think they are, but would like a confirmation).

Also, good thoughts on the other language stuff.

@garrensmith and I are talking about how to make this an extension rather than a direct change to documents/views.js. That should provide for some more interesting modularity.

BigBlueHat · 2014-01-22T14:58:46Z

@garrensmith @deathbearbrown I think my last commit uses establish() as intended. 😁 Let me know if not.

garrensmith · 2014-01-22T15:21:41Z

@BigBlueHat That looks right. Nice.

BigBlueHat · 2014-01-22T15:41:19Z

Status report for anyone watching (/me glances over at @kxepal).

@garrensmith and I are discussing making this a Fauxton extension and/or part of the Config addon. As it is now, it tangles the addons a bit and makes Documents unusable with pouchdb-server, Cloudant's Dashboard, and anyone else who might have a CouchDB API supporting product, but no /_config/ endpoint.

Making it an extension should also lay the ground work for Ruby, Python, and Erlang query servers + templates, etc.

Stay tuned. 📻

BigBlueHat · 2014-03-14T15:49:37Z

@garrensmith @kxepal @deathbearbrown

I can squash this before we merge it of course, but this should properly provide javascript + one (or eventually more) languages for design docs. Right now it's JS & CoffeeScript. I'll do a separate batch of language adds later.

@garrensmith I figure we can add the Fauxton.session.on('authenticated', ...) bits later.

garrensmith · 2014-03-14T15:54:10Z

src/fauxton/app/addons/documents/views.js

@@ -1324,9 +1353,13 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb, resizeColum
 updateReduce: function(event) {
 var $ele = $("#reduce-function-selector");
 var $reduceContainer = $(".control-group.reduce-function");
+ var langTemplate = _.filter(_.pluck(this.queryservers, this.language))[0];


Can you make _.filter(_.pluck(this.queryservers, this.language))[0]; its own method.

this.queryservers needs to be a function that takes a the language as a parameter.

garrensmith · 2014-03-14T16:16:47Z

hey @BigBlueHat, so far looking good. The only issue I'm getting is that you can save a coffeescript view to a design doc thats javascript. I think we have to do some validation around that.

garrensmith · 2014-03-14T16:39:23Z

src/fauxton/app/addons/config/resources.js

@@ -63,6 +63,7 @@ function (app, FauxtonAPI) {
 parse: function (resp) {
 return _.map(resp, function (section, section_name) {
 return {
+ id: section_name,


is this still needed?

Needed an additional mode for ACE for handling CoffeeScript (vs. JS). Once query servers are plugins (and can presumably also provide Fauxton plugins/addons) these modes should ship with their related query server.

Maybe someday Erlang will be the default. Maybe.

mode-coffeescript.js & worker-coffeescript.js are part of ACE which has a reference in NOTICE already, so no change there.

Yeah, who knew... This also properly sets the `this.language` bit in `beforeRender()`.

If there are no others

Also removed left over console.log from earlier

BigBlueHat · 2014-03-20T21:14:09Z

@garrensmith it's closer, I think. :)

I'm working on fixing the "saving coffeescript into a javascript ddoc" thing...but it's taking some heavy refactoring...and therefore time. My plan is to make the language selector it's own view and pass events between it and ViewEditor and DesignDocSelector.

I'd vote that we get this into master (so it doesn't go stale) and do a refactoring pass after that--mainly to keep things moving and not block on me sorting through all all these bits interrelate.

Tnx!

garrensmith · 2014-03-21T09:36:40Z

Refactoring the ViewEditor is a great idea, unfortunately @BigBlueHat this PR is not ready to be merged into master. Two things need to be done to make it usable. I've added the session.trigger("authenticated"); so that we can check the config only once the user has logged in. Could you add that in.

The second fix is when a user creates a new view. If a user creates a view for an existing design doc, then they cannot choose the language for the new view but must use the language that the design doc is set as (unless the design doc is empty, then they can choose which language to write the new view in). If a user selects a new design doc then the language option should appear and they can then choose what language this design doc is written in.

Once those two are implemented we should be ready to merge this in.

garrensmith · 2014-05-12T09:24:50Z

@BigBlueHat I think we should close this PR but keep the branch. It needs a fair amount of work before it can be merged. As shown in (COUCHDB-1870)[https://issues.apache.org/jira/browse/COUCHDB-1870] you have assigned it back to me. It will be awhile before I get to this.

BigBlueHat · 2014-05-12T12:40:01Z

Cool by me. Thanks, @garrensmith

This closes apache#137 Signed-off-by: ILYA Khlopotov <[email protected]>

let vm.args and sys.config as optional

* fix Dialyzer warning * fix formatting

Fixes for apache#137 and apache#142

* Update mango docs Remove some text references and update how index is chosen * fix from review

garrensmith reviewed Jan 22, 2014
View reviewed changes

garrensmith reviewed Mar 14, 2014
View reviewed changes

BigBlueHat added 10 commits March 20, 2014 09:47

added lang dropdown for ddocs; related ACE mode

9d1b9f9

Needed an additional mode for ACE for handling CoffeeScript (vs. JS). Once query servers are plugins (and can presumably also provide Fauxton plugins/addons) these modes should ship with their related query server.

reduceEditor language change handling

6de6304

defaultLang used for inital template loads

74ea411

Maybe someday Erlang will be the default. Maybe.

moved couchJSHINT default into components.js

e90f4eb

Fauxton conventions & PR feedback tweaks

34f06fb

coffeescript added to license.skip & Makefile.am

f6ac768

mode-coffeescript.js & worker-coffeescript.js are part of ACE which has a reference in NOTICE already, so no change there.

properly doing establish() for config promise

48eddf4

actually save the chosen design doc language

31a581e

Yeah, who knew... This also properly sets the `this.language` bit in `beforeRender()`.

fixed merge-caused bug

c60b368

tweaked design doc choice layout

a5f975b

BigBlueHat added 6 commits March 20, 2014 09:47

made new-doc use defaultLang

23e84b5

moved query server code into addon

f0ee246

fallback to single (javascript) ddoc lang

b9ed8be

If there are no others

loading queryservers list from _config

2c61245

switched to $.getJSON for smaller JSON req

bca40d5

Also removed left over console.log from earlier

turned this.queryservers into an object

6d9dc38

BigBlueHat closed this May 12, 2014

nickva pushed a commit to cloudant/couchdb that referenced this pull request Apr 21, 2017

Merge remote branch 'cloudant:3102-fix-config_subscription'

9e0ad34

This closes apache#137 Signed-off-by: ILYA Khlopotov <[email protected]>

lag-linaro pushed a commit to lag-linaro/couchdb that referenced this pull request Oct 25, 2018

Merge pull request apache#137 from bosqueviejo/master

4dfdd72

let vm.args and sys.config as optional

lag-linaro pushed a commit to lag-linaro/couchdb that referenced this pull request Oct 25, 2018

Fix issues introduced in apache#137 (4dfdd72)

dfba6dd

* fix Dialyzer warning * fix formatting

lag-linaro pushed a commit to lag-linaro/couchdb that referenced this pull request Oct 25, 2018

Merge pull request apache#155 from tuncer/fixes

988c9cd

Fixes for apache#137 and apache#142

janl pushed a commit that referenced this pull request Jan 5, 2020

Update mango docs (#137)

b78aa0a

* Update mango docs Remove some text references and update how index is chosen * fix from review

nickva pushed a commit to nickva/couchdb that referenced this pull request Sep 7, 2022

Update mango docs (apache#137)

7ebdc46

* Update mango docs Remove some text references and update how index is chosen * fix from review

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1870 add language option to mapreduce editor #137

1870 add language option to mapreduce editor #137

BigBlueHat commented Jan 21, 2014

BigBlueHat commented Jan 21, 2014

kxepal commented Jan 21, 2014

kxepal commented Jan 21, 2014

garrensmith commented Jan 22, 2014

garrensmith Jan 22, 2014

BigBlueHat Jan 22, 2014

BigBlueHat commented Jan 22, 2014

BigBlueHat commented Jan 22, 2014

garrensmith commented Jan 22, 2014

BigBlueHat commented Jan 22, 2014

BigBlueHat commented Mar 14, 2014

garrensmith Mar 14, 2014

garrensmith Mar 14, 2014

garrensmith commented Mar 14, 2014

garrensmith Mar 14, 2014

BigBlueHat commented Mar 20, 2014

garrensmith commented Mar 21, 2014

garrensmith commented May 12, 2014

BigBlueHat commented May 12, 2014

1870 add language option to mapreduce editor #137

1870 add language option to mapreduce editor #137

Conversation

BigBlueHat commented Jan 21, 2014

BigBlueHat commented Jan 21, 2014

kxepal commented Jan 21, 2014

kxepal commented Jan 21, 2014

garrensmith commented Jan 22, 2014

garrensmith Jan 22, 2014

Choose a reason for hiding this comment

BigBlueHat Jan 22, 2014

Choose a reason for hiding this comment

BigBlueHat commented Jan 22, 2014

BigBlueHat commented Jan 22, 2014

garrensmith commented Jan 22, 2014

BigBlueHat commented Jan 22, 2014

BigBlueHat commented Mar 14, 2014

garrensmith Mar 14, 2014

Choose a reason for hiding this comment

garrensmith Mar 14, 2014

Choose a reason for hiding this comment

garrensmith commented Mar 14, 2014

garrensmith Mar 14, 2014

Choose a reason for hiding this comment

BigBlueHat commented Mar 20, 2014

garrensmith commented Mar 21, 2014

garrensmith commented May 12, 2014

BigBlueHat commented May 12, 2014