Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loginUser wait for successful authentication #1258

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Make loginUser wait for successful authentication #1258

merged 1 commit into from
Mar 29, 2018

Conversation

eiri
Copy link
Member

@eiri eiri commented Mar 29, 2018 •
edited
Loading

Overview

On restrained hosts bcrypt and sometimes pbkdf2 can't finish hashing for new users within 5 sec timeout leading to tests failures. This fix makes loginUser to actually wait for successful authentication.

Testing recommendations

Javascript test suite should pass on both Travis and Jenkins

Related Issues or Pull Requests

Fixes #1238

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@janl janl merged commit 6ffe042 into apache:master Mar 29, 2018
@janl janl mentioned this pull request Mar 29, 2018
Closed
@eiri eiri deleted the make-login_user-wait-in-sec-tests branch March 29, 2018 17:39
@wohali wohali mentioned this pull request Jul 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janl janl janl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix users_db_security.js delete/recreate _users DB
2 participants
@eiri @janl