Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[BEAM-7916] Add ElasticsearchIO query parameter to take a ValueProvider" #9305

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Revert "[BEAM-7916] Add ElasticsearchIO query parameter to take a ValueProvider" #9305

merged 1 commit into from
Aug 9, 2019

Conversation

aromanenko-dev
Copy link
Contributor

It was mistakenly merged into branch release-2.14.0 instead of master

RyanSkraba
RyanSkraba approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@RyanSkraba RyanSkraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my, LGTM of course -- my apologies for not noticing on the original PR, I saw that there was a closed PR on 2.14.0, and missed that the new PR was also on the wrong branch!

@aromanenko-dev aromanenko-dev merged commit 968a806 into release-2.14.0 Aug 9, 2019
@aromanenko-dev aromanenko-dev deleted the revert-9285-BEAM-7916_Query_ValueProvider branch August 9, 2019 10:33
@oliverhenlich oliverhenlich mentioned this pull request Aug 12, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanSkraba RyanSkraba RyanSkraba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aromanenko-dev @RyanSkraba