[BEAM-7916] Add ElasticsearchIO query parameter to take a ValueProvider

[oliverhenlich]

We need to be able to perform Elasticsearch queries that are dynamic. The problem is ElasticsearchIO.read().withQuery() only accepts a string which means the query must be known when the pipleline/Google Dataflow Template is built.

This change changes the withQuery() parameter from String to ValueProvider<String>.

R: @timrobertson100
R: @jbonofre
R: @echauchot

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• @jbonofre, @echauchot
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.

Post-Commit Tests Status (on master branch)

Lang	SDK	Apex	Dataflow	Flink	Gearpump	Samza	Spark
Go		---	---		---	---
Java
Python		---			---	---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website
Non-portable
Portable	---		---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

[RyanSkraba]

For info: @jbonofre and @echauchot are not available this week, you might want to find an alternate reviewer.

For what it's worth, LGTM but I would highly recommend the suggested change for compatibility.

[oliverhenlich]

Thanks @RyanSkraba.
The only other person in the OWNERS file is @timrobertson100. Is that ok? How would I go about trying to find another reviewer?

[aromanenko-dev]

Thanks for contribution! LGTM after @RyanSkraba requested changes.

[oliverhenlich]

Hi @aromanenko-dev,
Thanks for merging this! I just realized that it's been merged into 2.14.0 which has already been released. Will that make it into the next version? What is the next version? On the Jira it says 2.16.0.

[aromanenko-dev]

@oliverhenlich Yes, my bad, I didn't pay an attention that this PR was against release-2.14.0 branch instead of master. Thank you for pointing on this.
I'll revert this commit (since release 2.14 is already done) and could you create another PR against master branch?

[oliverhenlich]

Hi @aromanenko-dev, sorry for the delay! Just got back to this. It looks like you've already taken care of this with PR: #9305 and #9314. Do I still need to do something?

What version would this fix then appear in 2.15?

PS: I noticed the last PR #9314 is failing but I don't think it has anything to do with my change.

[aromanenko-dev]

Hi @oliverhenlich, yes, I reverted commit in release-2.14.0 and created new PR against master (I cherry-picked your commit, so your credits should be kept). So, I think there is nothing to do for now from your side. This fix will appear in 2.16 since 2.15 branch was already cut 2 weeks ago.

PS: Yes, you are right, it was not related to your changes, thanks to @RyanSkraba to rerun and it's ok now.