[BEAM-2233,BEAM-2223] Adjust TestSparkPipelineOptions registration; add per-runner profiles to Java 8 examples pom #3002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull request
mvn clean verify
.<Jira issue #>
in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
We have cascading failures:
include-runners
profile in the Java 8 examplesTestOptions
has a hard dep on hamcrest that we list asprovided
, putting a burden on usersTestSparkPipelineOptions
was registered, so the Spark runner had this same hard dep and class load timeoptions.as(MyUnregisteredOptions.class)
this will causeTestPipeline
/PipelineOptionsFactory
to crash with a parse error even if none of the unregistered options were presentThese should all be fixed, IMO as follows:
TestOptions
should either not use hamcrest or should declare a correct dependency (not resolved)TestSparkPipelineOptions
should either not need to be registered or should be allowed to be registered (expected resolution: no need to register)TestPipeline
/PipelineOptionsFactory
should not crash due to how options have been observed, when they are not mutated, and probably should just not crash at all