Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-2223] Do not register TestSparkPipelineOptions to avoid hard hamcrest dep #2999

Closed
wants to merge 1 commit into from

Conversation

kennknowles
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

We have an undocumented requirement that no subclass of TestPipelineOptions can be registered. We do not indicate a hard dependency on hamcrest, but test options has one and it will crash on registration (or classloading in general) if the user does not provide it.

I see this change as a short term solution, making the Spark registrar analogous to all the other runners. It allows Java 8 examples to get past the point of registration.

@kennknowles
Copy link
Member Author

run spark validatesrunner

@kennknowles
Copy link
Member Author

R: @davorbonaci

@kennknowles
Copy link
Member Author

CC: @aaltay

Copy link
Member

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennknowles
Copy link
Member Author

This actually will not work, due to how PipelineOptions and TestPipeline interact. Since it will not work as-is, I will close this and do all revision on #3002 which contains the commits in this PR.

@kennknowles kennknowles closed this May 9, 2017
@kennknowles kennknowles deleted the java8-examples branch May 26, 2017 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants