[BEAM-2223] Do not register TestSparkPipelineOptions to avoid hard hamcrest dep #2999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull request
mvn clean verify
.<Jira issue #>
in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
We have an undocumented requirement that no subclass of
TestPipelineOptions
can be registered. We do not indicate a hard dependency on hamcrest, but test options has one and it will crash on registration (or classloading in general) if the user does not provide it.I see this change as a short term solution, making the Spark registrar analogous to all the other runners. It allows Java 8 examples to get past the point of registration.