Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-1780] BigtableIO: better handling of bad split requests #2298

Closed
wants to merge 2 commits into from
Closed

[BEAM-1780] BigtableIO: better handling of bad split requests #2298

wants to merge 2 commits into from

Commits on Mar 22, 2017

  1. [BEAM-1780] BigtableIO: better handling of bad split requests 

    The contract for `splitIntoFraction` is that it should only throw if the
reader is in an unknown, bad state. The proper way to reject invalid or
unsatisfiable split requests is to return null.

However, `BigtableIO.Read` will currently throw for simply invalid input
it should reject. This can lead to less effective dynamic work
rebalancing and even stuck jobs.

Related to, but probably not a complete solution for, BEAM-1751.
    @dhalperi
    dhalperi committed Mar 22, 2017
    Configuration menu
    Copy the full SHA
    3172c0a View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2017

  1. fixup -- Exception to RuntimeException

    @dhalperi
    dhalperi committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    eee3d48 View commit details
    Browse the repository at this point in the history