[BEAM-1780] BigtableIO: better handling of bad split requests #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contract for `splitIntoFraction` is that it should only throw if the reader is in an unknown, bad state. The proper way to reject invalid or unsatisfiable split requests is to return null. However, `BigtableIO.Read` will currently throw for simply invalid input it should reject. This can lead to less effective dynamic work rebalancing and even stuck jobs. Related to, but probably not a complete solution for, BEAM-1751.
|
R: @tgroh |
dhalperi
commented
Mar 23, 2017
| public final synchronized BigtableSource splitAtFraction(double fraction) { | ||
| ByteKey splitKey; | ||
| try { | ||
| splitKey = rangeTracker.getRange().interpolateKey(fraction); | ||
| } catch (IllegalArgumentException e) { | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
explicit broadening to catch unanticipated exceptions, as they can still not put the reader in a bad state.
|
Kicked of postcommit build https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_MavenInstall/2994/ |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contract for
splitIntoFractionis that it should only throw if thereader is in an unknown, bad state. The proper way to reject invalid or
unsatisfiable split requests is to return null.
However,
BigtableIO.Readwill currently throw for simply invalid inputit should reject. This can lead to less effective dynamic work
rebalancing and even stuck jobs.
Related to, but probably not a complete solution for, BEAM-1751.