Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9147] Add @Experimental annotation to VideoIntelligence related classes #11463

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

mwalenia
Copy link
Member

@mwalenia mwalenia commented Apr 20, 2020

This updates classes added in #11261 to be @experimental.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@mwalenia
Copy link
Member Author

R: @lukecwik
CC: @jkff

@iemejia
Copy link
Member

iemejia commented Apr 20, 2020

Can you please add the annotation into the package-info.java files too. This PR makes me thing we probably need a new Kind for these kind of transforms (and the extensions), maybe Kind.TRANSFORM WDYT @lukecwik and the others?

@mwalenia
Copy link
Member Author

@iemejia Sure, I added it.

@lukecwik
Copy link
Member

Can you please add the annotation into the package-info.java files too. This PR makes me thing we probably need a new Kind for these kind of transforms (and the extensions), maybe Kind.TRANSFORM WDYT @lukecwik and the others?

Kind.TRANSFORM seems vague since many of our IOs would fall under that as well.

@lukecwik lukecwik merged commit d2089bc into master Apr 20, 2020
@lukecwik
Copy link
Member

lukecwik commented Apr 20, 2020

@ibzib Please cherrypick into 2.21 release.

@mwalenia mwalenia deleted the BEAM-9147-add-experimental-annotation branch June 21, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants