-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9147] Add a VideoIntelligence transform to Java SDK #11261
Conversation
Run CommunityMetrics PreCommit |
1 similar comment
Run CommunityMetrics PreCommit |
@Ardagan can you take a look at this or delegate to somebody else? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused which binary will these classes be added to. Do we need update of release process?
@Override | ||
public Void apply(Iterable<List<VideoAnnotationResults>> input) { | ||
List<Boolean> labelEvaluations = new ArrayList<>(); | ||
input.forEach( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is really hard to read. Would be good to add named methods or use similar approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, done. What do you think?
settings.gradle
Outdated
@@ -165,3 +165,6 @@ include "beam-test-infra-metrics" | |||
project(":beam-test-infra-metrics").dir = file(".test-infra/metrics") | |||
include "beam-test-tools" | |||
project(":beam-test-tools").dir = file(".test-infra/tools") | |||
include 'sdks:java:extensions:ml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this up to the rest of extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, fixed
I'm not sure how I can check this, do you have any pointers? |
Run CommunityMetrics PreCommit |
Run Python PreCommit |
Run CommunityMetrics PreCommit |
Run Python Precommit |
Run CommunityMetrics PreCommit |
Community metrics should be irrelevvant failure. |
Run CommunityMetrics PreCommit |
1 similar comment
Run CommunityMetrics PreCommit |
* [BEAM-9147] Add Google Cloud AI VideoIntelligence integration transform
Hi! Drive-by comment: in the current form this transform violates the PTransform Style Guide, specifically, it exposes a set of There are several very compelling advantages to exposing Could you consider restructuring it in a follow-up PR? A similar DoFn-like PTransform you can take example from is Regex. Thanks! |
This PR adds a VideoIntelligence transform to Java SDK, analogous to Python transforms introduced
in #10764.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.