Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-9529] Remove datastore.v1, googledatastore #11175

Merged
merged 3 commits into from
Apr 8, 2020
Merged

[BEAM-9529] Remove datastore.v1, googledatastore #11175

merged 3 commits into from
Apr 8, 2020

Commits on Mar 20, 2020

  1. [BEAM-9529] Remove datastore.v1, googledatastore 

    - Remove googledatastore and proto-google-cloud-datastore-v1 packages.
- Remove v1/datastoreio.py and other v1/ sources that aren't also used by
v1new. The rest were migrated into v1new/.
- Migrated inherited test cases from v1 into v1new test classes.
- Update datastore_wordcount IT to use v1new. Now also runs on Python 3.
- Added some type hints to v1new/types.py for IDE (PyCharm) ease-of-use.
- Update Datastore snippet to use v1new, now works for Py3.
    @udim
    udim committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    83e0e19 View commit details
    Browse the repository at this point in the history

  2. Add changes

    @udim
    udim committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    0e9ab85 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Don't fail in non-cloud unit test envs 

    Fix lint
    @udim
    udim committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    767dcd3 View commit details
    Browse the repository at this point in the history