[BEAM-9529] Remove datastore.v1, googledatastore #11175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove googledatastore and proto-google-cloud-datastore-v1 packages. - Remove v1/datastoreio.py and other v1/ sources that aren't also used by v1new. The rest were migrated into v1new/. - Migrated inherited test cases from v1 into v1new test classes. - Update datastore_wordcount IT to use v1new. Now also runs on Python 3. - Added some type hints to v1new/types.py for IDE (PyCharm) ease-of-use. - Update Datastore snippet to use v1new, now works for Py3.
|
run python 3.7 postcommit |
|
R: @chamikaramj |
|
Note to reviewer: there is practically no change to connector code. Most of the changes involve tests, example code, and snippets. |
|
LGTM. Thanks. |
|
Run Python2_PVR_Flink PreCommit |
suztomo
pushed a commit
to suztomo/beam
that referenced
this pull request
Apr 10, 2020
* [BEAM-9529] Remove datastore.v1, googledatastore - Remove googledatastore and proto-google-cloud-datastore-v1 packages. - Remove v1/datastoreio.py and other v1/ sources that aren't also used by v1new. The rest were migrated into v1new/. - Migrated inherited test cases from v1 into v1new test classes. - Update datastore_wordcount IT to use v1new. Now also runs on Python 3. - Added some type hints to v1new/types.py for IDE (PyCharm) ease-of-use. - Update Datastore snippet to use v1new, now works for Py3.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1new. The rest were migrated into v1new/.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.