Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit CLI warning log msg on non 64-bit hardware #3215

Merged
merged 2 commits into from
May 21, 2024
Merged

Emit CLI warning log msg on non 64-bit hardware #3215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7659854
Emit CLI warning log msg on non 64-bit hardware
sug0 May 9, 2024
355785f
Changelog for #3215
sug0 May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/miscellaneous/3215-warn-on-non-64bit-arch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Emit CLI warning log msg on non 64-bit node hardware.
([\#3215](https://github.com/anoma/namada/pull/3215))
20 changes: 20 additions & 0 deletions crates/apps/src/lib/node/ledger/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,28 @@ pub fn migrating_state() -> Option<BlockHeight> {
height.parse::<u64>().ok().map(BlockHeight)
}

/// Emit a header of warning log msgs if the host does not have
/// a 64-bit CPU.
fn emit_warning_on_non_64bit_cpu() {
if std::mem::size_of::<usize>() != 8 {
tracing::warn!("");
tracing::warn!(
"Your machine has a {}-bit CPU...",
8 * std::mem::size_of::<usize>()
);
tracing::warn!("");
tracing::warn!("A majority of nodes will run on 64-bit hardware!");
tracing::warn!("");
tracing::warn!("While not immediately being problematic, non 64-bit");
tracing::warn!("nodes may run into spurious consensus failures.");
tracing::warn!("");
}
}

/// Run the ledger with an async runtime
pub fn run(config: config::Ledger, wasm_dir: PathBuf) {
emit_warning_on_non_64bit_cpu();

let logical_cores = num_cpus::get();
tracing::info!("Available logical cores: {}", logical_cores);

Expand Down
Loading