Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit CLI warning log msg on non 64-bit hardware #3215

Merged
merged 2 commits into from
May 21, 2024

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented May 9, 2024

Describe your changes

Closes #826

Indicate on which release or other PRs this topic is based on

v0.35.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@sug0 sug0 added the ledger label May 9, 2024
@sug0 sug0 requested review from tzemanovic and cwgoes May 9, 2024 14:14
cwgoes
cwgoes previously approved these changes May 9, 2024
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covers the condition we want, though it would be nice to abstract into a function.

@sug0 sug0 added the security label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 60.23%. Comparing base (4ed6229) to head (355785f).

Files Patch % Lines
crates/apps/src/lib/node/ledger/mod.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3215      +/-   ##
==========================================
- Coverage   60.24%   60.23%   -0.02%     
==========================================
  Files         303      303              
  Lines       93191    93207      +16     
==========================================
- Hits        56145    56139       -6     
- Misses      37046    37068      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone
Copy link
Contributor

Is this ready for draft in its current state?

sug0 added a commit that referenced this pull request May 10, 2024
@sug0 sug0 force-pushed the tiago/warn-on-non-64bit-arch branch from 7ce4dd3 to 355785f Compare May 10, 2024 07:47
brentstone added a commit that referenced this pull request May 10, 2024
* tiago/warn-on-non-64bit-arch:
  Changelog for #3215
  Emit CLI warning log msg on non 64-bit hardware
@tzemanovic tzemanovic merged commit f6daec7 into main May 21, 2024
15 of 19 checks passed
@tzemanovic tzemanovic deleted the tiago/warn-on-non-64bit-arch branch May 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit the codebase for erroneous usage of architecture dependent types
4 participants