test(core): Add testing for defer error block #56561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
approved these changes
Jun 23, 2024
AndrewKushnir
added
target: patch
In angular#56558 it was raised that we used an devMode function in a prod scope. This commit adds a test when an defer error block is missing in devMode and prodMode
JeanMeche
force-pushed
the
test/defer-error
branch
from
5c4b1ed
to
3db5a98
Compare
JeanMeche
added
action: merge
thePunderWoman
pushed a commit
that referenced
this pull request
Jun 27, 2024
|
This PR was merged into the repository by commit d23aa87. The changes were merged into the following branches: main, 18.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #56559:
In #56558 it was raised that we used an devMode function in a prod scope.
This commit adds a test when an defer error block is missing in devMode and prodMode