fix(core): prevent calling devMode only function on @defer error.

[JeanMeche]

getTemplateLocationDetails() is a devMode only function and should be guarded by ngDevMode or invoking it will throw an error.

fixes #56558

[JeanMeche]

Note: It might be worth adding a test to cover that. It looks like we have no test that covers the DEFER_LOADING_FAILED error.

[AndrewKushnir]

@JeanMeche thanks for the fix 👍

[AndrewKushnir]

Note: It might be worth adding a test to cover that. It looks like we have no test that covers the DEFER_LOADING_FAILED error.

If we are missing tests for the failed loading scenario (specifically when there is no @error template provided) - it'd be great to add them, but let's do it in a separate PR.

[AndrewKushnir]

@JeanMeche there is a failing test CI job, which needs an update to symbol golden files. Could you please take a look when you get a chance?

[AndrewKushnir]

Presubmit.

[dylhunn]

This PR was merged into the repository by commit 5be16d0.

The changes were merged into the following branches: main, 18.0.x

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}