Add tracing and JankStats #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently tracing sync and main navigation.
Change-Id: I420cfaf826fee770975164147c29280a760bb5ff
Change-Id: I3b038a9bbc6eed9b21343aa0fd75c044049386a4
…election Change-Id: I1b7820ebd4d9e16f0aa4d576c250e5aa137706c0
Change-Id: I5d4fddb9fb36a40ae9864edfa6eb4850d8f8d306
Change-Id: I8a5d90188b52ec1c11eec1c2724dda1332615768
Change-Id: I4ee60188fffdad4678f0f5a0ee4ef47031a1d61f
Change-Id: Idcab0faa2e9b4cc9986064f45217cab101843697
Change-Id: Ia371c564e4ff723fbeaca741d278174bd6db0dd8
Change-Id: Icb85b612b1aa45fc5579acea9358a2da70de15d6
…nto bw/initialMetrics
This isn't the thing a developer should be focusing on when first opening the file. So moving it further down in the composable.
keyboardsurfer
force-pushed
the
bw/initialMetrics
branch
from
9b66621
to
6509b6a
Compare
tunjid
reviewed
Jul 1, 2022
JolandaVerhoef
requested changes
Jul 5, 2022
app/src/main/java/com/google/samples/apps/nowinandroid/MainActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
Outdated
Show resolved
Hide resolved
...-foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/AuthorsCarousel.kt
Outdated
Show resolved
Hide resolved
* Introduce gradle plugin for firebase perf * Create TrackScrollJank composable to mask tracking code
|
This branch has merge conflicts, can you resolve those? |
|
All resolved. |
...-foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/AuthorsCarousel.kt
Outdated
Show resolved
Hide resolved
...ure-foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt
Outdated
Show resolved
Hide resolved
|
I agree with creating a learning journey for the performance additions and have tracked it in #181. |
keyboardsurfer
force-pushed
the
bw/initialMetrics
branch
from
d9bf5b9
to
7c2b584
Compare
JolandaVerhoef
approved these changes
Jul 18, 2022
|
Please wait with merging until Don has also reviewed! |
dturner
requested changes
Jul 18, 2022
There was a problem hiding this comment.
As @JolandaVerhoef already suggested, please add supporting documentation for this plugin/feature, either by adding to the existing README or (better) start a performance tracking learning journey.
The docs should include:
- The events which are being monitored
- How the events are currently recorded, and how they could be sent to a Firebase backend (see below)
- An example output, what the output means and potentially how to address jank. For example, when running the app on the emulator I see the following output:
V/NiA Jank: FrameData(frameStartNanos=13037274863989, frameDurationUiNanos=286913934, frameDurationCpuNanos=293708517, frameOverrunNanos=277093643, isJank=true, states=[Navigation: for_you_route])
But, as a layman, I'm not sure what this is telling me, or what (if anything) I should do about it.
I'd also like to see a prod configuration which switches the event recording from using Log to using a real backend, although this can be done in a follow up PR.
dturner
approved these changes
Jul 18, 2022
|
That's what the issue is for. I've also added it to my internal task tracker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable performance monitoring with JankStats and improve inspection results with Trace sections for some parts of the app.