Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Create performance learning journey #181

Open
2 tasks done
keyboardsurfer opened this issue Jul 18, 2022 · 1 comment
Open
2 tasks done

[FR]: Create performance learning journey #181

keyboardsurfer opened this issue Jul 18, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@keyboardsurfer
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Describe the problem

We're adding performance inspection code to the app.
@JolandaVerhoef recommended creating a learning journey for this.

Describe the solution

Let's create a learning journey.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@keyboardsurfer
Copy link
Member Author

Adding @dturner's comment to keep track:

As @JolandaVerhoef already suggested, please add supporting documentation for this plugin/feature, either by adding to the existing README or (better) start a performance tracking learning journey.

The docs should include:

The events which are being monitored
How the events are currently recorded, and how they could be sent to a Firebase backend (see below)
An example output, what the output means and potentially how to address jank. For example, when running the app on the emulator I see the following output:
V/NiA Jank: FrameData(frameStartNanos=13037274863989, frameDurationUiNanos=286913934, frameDurationCpuNanos=293708517, frameOverrunNanos=277093643, isJank=true, states=[Navigation: for_you_route])
But, as a layman, I'm not sure what this is telling me, or what (if anything) I should do about it.

I'd also like to see a prod configuration which switches the event recording from using Log to using a real backend, although this can be done in a follow up PR.

@keyboardsurfer keyboardsurfer removed their assignment Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants