Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1008: Use capitalized variant name when registering badging tasks #1009

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

lihenggui
Copy link
Contributor

@lihenggui lihenggui commented Oct 31, 2023

What I have done and why
Use capitalized variant names when registering badging tasks.

Before:
image

After
image

Fixes #1008

Do tests pass?

  • [✓] Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • [✓] Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

Is this your first pull request?

Copy link
Collaborator

@dturner dturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, and for fixing the trailing commas.

Usually I'd request that the formatting changes be done in a separate PR but in this case it's still fairly obvious what is being changed.

@dturner dturner merged commit 59994b9 into android:main Nov 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Variant name is not capitalized in the Gradle task list
2 participants