[Bug]: Variant name is not capitalized in the Gradle task list #1008
Labels
bug
Something isn't working
Comments
lihenggui
added a commit
to lihenggui/nowinkmp
that referenced
this issue
Oct 31, 2023
dturner
added a commit
that referenced
this issue
Nov 1, 2023
Fix #1008: Use capitalized variant name when registering badging tasks
dturner
added a commit
to thatfiredev/nowinandroid
that referenced
this issue
Nov 2, 2023
* main: Fix action name and version Apply spotless automatically during build and commit back to PR Fix android#1008: Use capitalized variant name when registering gradle tasks Change-Id: I32f6dc608179586357ed017ae35a05ca97389559
dturner
added a commit
to danysantiago/nowinandroid
that referenced
this issue
Nov 8, 2023
# By Simon Marquis (23) and others # Via GitHub (39) and TM (1) * main: (67 commits) Update MainDispatcherRule.kt Use specific task name for updating badging Use SdkConstants for getting aapt2 executable location Revert "Apply spotless automatically during build and commit to PR" Fix action name and version Apply spotless automatically during build and commit back to PR Fix android#1008: Use capitalized variant name when registering gradle tasks Add automatic checks for badging refactor/Convert object to data object in sealed interface Rollback runtime tracing version to avoid pulling in new Compose runtime Update all dependencies Update lint/src/main/kotlin/com/google/samples/apps/nowinandroid/lint/NiaIssueRegistry.kt Remove underscore check Inline color values for app icons Removed Comments Use colors from design palette in build variant icons Update pull request template Fix for pull request template not being used. Fixes android#769 Create different icons for each build variant Restore lazy API call ... Change-Id: I99430b4263108708c78dc6e370d76ed81e66814b # Conflicts: # app/build.gradle.kts # core/datastore/build.gradle.kts # core/domain/build.gradle.kts # core/network/src/demo/kotlin/com/google/samples/apps/nowinandroid/core/network/di/FlavoredNetworkModule.kt # core/network/src/prod/kotlin/com/google/samples/apps/nowinandroid/core/network/di/FlavoredNetworkModule.kt # gradle/libs.versions.toml # sync/work/build.gradle.kts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Is there a StackOverflow question about this issue?
What happened?
In the task list, you will notice that the variant name in the task is not properly capitalized. It is not a bug that will prevent users from running this task, but we'd better keep the same naming convention.
Example:
Expected behavior
Variant names 'prod' and 'demo' should be capitalized correctly.
Causes
Value in
variant.nameis not in a capitalized formhttps://github.com/android/nowinandroid/pull/1001/files#diff-b32c0825279a2b8ec215b50d3147d324bc248198ceb0b352de59c47b2cd06533R105
Relevant logcat output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: