Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input templating function and specific template for custom date range #26

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

kevinfodness
Copy link
Member

  • Adds a generic templating function called input that can be used on any aggregation to output a recommended set of form controls for the aggregation, which can be overridden by individual aggregations to customize the form fields.
  • Sets the default for all aggregations to checkboxes.
  • Defaults the relative date aggregation to a select.
  • Adds a custom set of inputs for the custom date range aggregation's input function which handles date selection using a built-in date input and a hidden field to track the ISO-8601 date separately from the date input.

Copy link

@vancoder vancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎧

@kevinfodness kevinfodness merged commit 372d847 into main Aug 5, 2022
@kevinfodness kevinfodness deleted the feature/custom-date-range-templating branch August 5, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants