Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(getChangelog): wrong argument name #448

Merged
merged 2 commits into from
Nov 26, 2019
Merged

fix(getChangelog): wrong argument name #448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d200896
fix getChangelog second argument name
jeetiss Nov 25, 2019
def5971
Merge branch 'master' into fix/get-changelog
Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/shipjs/src/helper/getChangelog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import path from 'path';
import fs from 'fs';
import { extractSpecificChangelog } from './';

export default function getChangelog({ version, rootDir }) {
const changelogPath = path.resolve(rootDir, 'CHANGELOG.md');
export default function getChangelog({ version, dir }) {
const changelogPath = path.resolve(dir, 'CHANGELOG.md');
try {
const changelogFile = fs.readFileSync(changelogPath, 'utf-8').toString();
return extractSpecificChangelog({ changelogFile, version });
Expand Down