Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(getChangelog): wrong argument name #448

Merged
merged 2 commits into from
Nov 26, 2019
Merged

fix(getChangelog): wrong argument name #448

merged 2 commits into from
Nov 26, 2019

Conversation

jeetiss
Copy link
Contributor

@jeetiss jeetiss commented Nov 25, 2019

npm run release:trigger ends with this error:

› Creating a release on GitHub repository
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at validateString (internal/validators.js:112:11)
    at Proxy.resolve (path.js:981:7)
    at getChangelog (/Users/jeetiss/Projects/try-shipjs/node_modules/shipjs/src/helper/getChangelog.js:7:46)

fix that

@jeetiss jeetiss changed the title fix getChangelog second argument name fix: getChangelog second argument name Nov 25, 2019
@eunjae-lee eunjae-lee changed the title fix: getChangelog second argument name fix(getChangelog): wrong argument name Nov 26, 2019
eunjae-lee
eunjae-lee approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
I even didn't know if we had this bug.

@eunjae-lee eunjae-lee merged commit e378e06 into algolia:master Nov 26, 2019
@jeetiss jeetiss deleted the fix/get-changelog branch November 26, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunjae-lee eunjae-lee eunjae-lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeetiss @eunjae-lee