Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Before run Shipjs section #427

Merged
merged 2 commits into from
Nov 20, 2019
Merged

docs: add Before run Shipjs section #427

merged 2 commits into from
Nov 20, 2019

Conversation

tyankatsu0105
Copy link
Contributor

re #414

Haroenv
Haroenv reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Ideally I think the first release should be made when you set it up (or it should be able to deal with no release yet done), but it should be documented anyway

.tool-versions Outdated Show resolved Hide resolved
@Haroenv Haroenv merged commit a528036 into algolia:master Nov 20, 2019
@tyankatsu0105 tyankatsu0105 deleted the docs/add-first-step branch November 20, 2019 15:45
@eunjae-lee
Copy link
Contributor

eunjae-lee commented Nov 21, 2019 •
edited

@tyankatsu0105 Thanks for the contribution 🎉
Feel free to open a new PR to add yourself as a contributor.
nevermind. already done 👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tyankatsu0105 @eunjae-lee @Haroenv