Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First release flow #414

Closed
jeetiss opened this issue Nov 12, 2019 · 6 comments
Closed

First release flow #414

jeetiss opened this issue Nov 12, 2019 · 6 comments

Comments

@jeetiss
Copy link
Contributor

jeetiss commented Nov 12, 2019

Is your feature request related to a problem? Please describe.
When I added ship.js for new library that is never published, I got error message

npm run release:prepare

> @jeetiss/try-shipjs@ release:prepare /Users/jeetiss/Projects/try-shipjs
> shipjs prepare

› Checking the current status.
Failed to prepare a release for the following reason(s).
  - There is no git tag for the current version (v0.0.0)

And I don't know how fix that

Describe the solution you'd like
We need describe first release flow better, and specify version that means unreleased package, like 0.0.0 or empty string.

Describe alternatives you've considered
Don't know

Additional context
Setup script that you added is so helpful ❤️
PS: I'm learning English now, fill free to edit my message for fixing some mistakes, and I hope that my message is understandable 🙏🏻

@Haroenv
Copy link
Contributor

Haroenv commented Nov 12, 2019

does this error happen on npx shipjs setup? Just clarifying

@jeetiss
Copy link
Contributor Author

jeetiss commented Nov 12, 2019

this error happen on shipjs prepare

You can see all attempts to fix this in my try-shipjs repo

@jeetiss
Copy link
Contributor Author

jeetiss commented Nov 12, 2019

I find --first-release flag in help, but it doesn't skip git tag validation

shipjs prepare --first-release
› Checking if `hub` exists.
› Checking the current status.
Failed to prepare a release for the following reason(s).
  - There is no git tag for the current version (v0.0.1)

@tyankatsu0105
Copy link
Contributor

Hi! @jeetiss 👋
I had same issue before.

You need to release first version.

<release-types> : ex) patch,minor,major
See npm-version | npm Documentation

git checkout master
npm version <release-types>
git push origin master
git push --tags

And then, You can run npm run release:prepare after some commits.👍

@jeetiss
Copy link
Contributor Author

jeetiss commented Nov 18, 2019

Hi! @tyankatsu0105 🙌🏻

thanks for help

I think that this steps should shipjs do and this will be so helpful

what do you think? @Haroenv, @eunjae-lee
I can help if you agree with this

@eunjae-lee
Copy link
Contributor

thinking of improving first-trying users' experience.
thanks for the doc which will save people in the meantime :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants