Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): allow select to work with empty values in nb-option #1282

Merged
merged 15 commits into from
Apr 18, 2019
Merged

fix(select): allow select to work with empty values in nb-option #1282

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c298854
fix(select): update select to work with empty values
aefox Mar 7, 2019
63fb7ff
remove calls to fit
aefox Mar 7, 2019
e1f17a1
updated empy value check to use loose comparison to null
aefox Mar 7, 2019
fdcadec
added missing trailing comma to fix linting
aefox Mar 7, 2019
a48cfb9
Merge branch 'master' into fix/select-with-empty-values
yggg Apr 11, 2019
62eaa67
refactor(select): use positive comparision
yggg Apr 11, 2019
8ba4f5d
docs(select): add more clean options examples
yggg Apr 11, 2019
6d83436
fix: remove truthy value filter
yggg Apr 12, 2019
e683e87
test(select): extract and refactor falsy values tests
yggg Apr 12, 2019
53189a7
fix(select): render checkbox in options with non-reset falsy values
yggg Apr 12, 2019
d27f381
Merge branch 'master' into fix/select-with-empty-values
yggg Apr 12, 2019
6991ce4
test(select): select option with value
yggg Apr 14, 2019
8a4805d
Merge branch 'next' into fix/select-with-empty-values
yggg Apr 18, 2019
b212371
Merge branch 'next' into fix/select-with-empty-values
yggg Apr 18, 2019
2ca0928
Merge branch 'next' into fix/select-with-empty-values
yggg Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(select): select option with value
  • Loading branch information
@yggg
yggg committed Apr 14, 2019
commit 6991ce41e8b9589a552a93e4b033a96359819020
2 changes: 1 addition & 1 deletion src/framework/theme/components/select/select.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ describe('Component: NbSelectComponent', () => {
const testComponent = selectFixture.componentInstance;
selectFixture.detectChanges();

const optionToSelect = testComponent.options.last;
const optionToSelect = testComponent.options.find(o => o.value != null);
const optionSelectSpy = spyOn(optionToSelect, 'select').and.callThrough();

expect(optionToSelect.selected).toEqual(false);
Expand Down