fix(select): allow select to work with empty values in nb-option #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aefox
commented
Mar 7, 2019
2 tasks
2 tasks
yggg
suggested changes
Mar 12, 2019
Accidentally removed during conflict resolution.
nnixaa
approved these changes
Apr 18, 2019
Codecov Report
@@ Coverage Diff @@
## next #1282 +/- ##
==========================================
+ Coverage 82.54% 82.56% +0.02%
==========================================
Files 237 237
Lines 7274 7274
Branches 635 635
==========================================
+ Hits 6004 6006 +2
Misses 1080 1080
+ Partials 190 188 -2
|
yggg
approved these changes
Apr 18, 2019
yggg
pushed a commit
that referenced
this pull request
May 27, 2019
BREAKING CHANGE: Only 'null' and 'undefined' option values now considered as reset. false and falsy values such as 0, '', NaN don't reset select value anymore.
yggg
pushed a commit
that referenced
this pull request
Jun 5, 2019
BREAKING CHANGE: Only 'null' and 'undefined' option values now considered as reset. false and falsy values such as 0, '', NaN don't reset select value anymore.
yggg
pushed a commit
that referenced
this pull request
Jun 6, 2019
BREAKING CHANGE: Only `null` and `undefined` option values now considered as reset. `false` and falsy values such as `0`, `''`, `NaN` don't reset select value anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
This PR fixes #1235 and in order to allow
nb-optionshave values of""or"0".These changes also end up fixes #1260.
BREAKING CHANGE:
Only 'null' and 'undefined' option values now considered as reset.
falseand falsy values such as0,'',NaNdon't reset select value anymore.