Fixes setting initial progress of Lottie animation #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setting initial progress of the animation (This was noticeable particularly in React-Native projects due to didMoveToSuperview calling setNeedsAnimationUpdate before the view was in a window, and then the didMoveToWindow call being blocked
This was referenced May 26, 2017
buba447
approved these changes
Jun 7, 2017
NSGolova
pushed a commit
to clario-tech/lottie-ios
that referenced
this pull request
Nov 19, 2020
Fixes setting initial progress of Lottie animation
calda
pushed a commit
that referenced
this pull request
Dec 1, 2022
Fixes setting initial progress of Lottie animation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only updates animation if the view has a window to avoid issues with setting
initial progress of the animation (This was noticeable particularly in React-Native
projects due to didMoveToSuperview calling setNeedsAnimationUpdate before the
view was in a window, and then the didMoveToWindow call being blocked)
This is related to:
#91
But fixes it more extensively to handle situations where your view is added to it's superview before it is in a window like when being used in react-native like here:
lottie-react-native/lottie-react-native#122