Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting initial progress only works asynchronously #122

Closed
ragnorc opened this issue Apr 25, 2017 · 6 comments
Closed

Setting initial progress only works asynchronously #122

ragnorc opened this issue Apr 25, 2017 · 6 comments

Comments

@ragnorc
Copy link

ragnorc commented Apr 25, 2017

When setting the progress prop of the animation to 1 the animation does not show up.
It only works using an async function such as setTimeout in componentWillMount().

componenentWillMount() {
setTimeout(()=>{this.setState({progress: 1})}, 1);
}

Related: airbnb/lottie-ios#91
airbnb/lottie-ios#56

@ragnorc ragnorc changed the title Setting progress only works asynchronously Setting initial progress only works asynchronously Apr 25, 2017
@simonmitchell
Copy link

Did you have any luck with this @ragnorc? It seems like they've fixed it in the Lottie library, but it's still broken for me in lottie-react-native

@simonmitchell
Copy link

See PR here: airbnb/lottie-ios#245

@ragnorc
Copy link
Author

ragnorc commented Jun 3, 2017

@simonmitchell No luck yet. Still waiting for them to fix it in RN as well.

@simonmitchell
Copy link

I've submitted a PR to fix it which you can see above :) if you want to give our fork a go, let me know if it works okay for you!

@ragnorc
Copy link
Author

ragnorc commented Jun 3, 2017

@simonmitchell Awesome!

@gpeal
Copy link
Collaborator

gpeal commented Nov 24, 2017

This should be fixed in the latest release! Feel free to reopen if it's still an issue.

@gpeal gpeal closed this as completed Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants