Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements during layout calculation #122

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Performance improvements during layout calculation #122

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f46b240
Performance improvements during layout calculation
Mar 4, 2024
ab43b44
Update MagazineLayout/LayoutCore/ModelState.swift
elfredpagan Mar 4, 2024
c837be0
Update MagazineLayout/LayoutCore/ModelState.swift
elfredpagan Mar 4, 2024
6b40f82
Update MagazineLayout/LayoutCore/ModelState.swift
elfredpagan Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update MagazineLayout/LayoutCore/ModelState.swift 
Co-authored-by: Bryan Keller <[email protected]>
  • Loading branch information
@elfredpagan @bryankeller
elfredpagan and bryankeller committed Mar 4, 2024
commit c837be09148029dae70eb08186dc609438180f49
2 changes: 1 addition & 1 deletion MagazineLayout/LayoutCore/ModelState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ final class ModelState {
}

func removeHeader(forSectionAtIndex sectionIndex: Int) {
if(currentSectionModels[sectionIndex].removeHeader()) {
if currentSectionModels[sectionIndex].removeHeader() {
invalidateSectionMaxYsCacheForSectionIndices(startingAt: sectionIndex)
prepareElementLocationsForFlattenedIndices()
}
Expand Down