Performance improvements during layout calculation #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `invalidateSectionMaxYsCacheForSectionIndices` and `invalidateEntireSectionMaxYsCache` do linear passes. These are called on each section header, section footer and background. Leading to a lot of work being done with long lists. This PR short circuits the work if we try to remove header, footers and backgrounds that don't exist. A better option would be to run the calls above once per update vs per update item. That would require a bit more rework though.
bryankeller
reviewed
Mar 4, 2024
bryankeller
reviewed
Mar 4, 2024
bryankeller
reviewed
Mar 4, 2024
Co-authored-by: Bryan Keller <[email protected]>
Co-authored-by: Bryan Keller <[email protected]>
Co-authored-by: Bryan Keller <[email protected]>
|
applied the changes. |
bryankeller
approved these changes
Mar 4, 2024
bryankeller
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Both
invalidateSectionMaxYsCacheForSectionIndicesandinvalidateEntireSectionMaxYsCachedo linear passes. These are called on each section header, section footer and background. Leading to a lot of work being done with long lists.This PR short circuits the work if we try to remove header, footers and backgrounds that don't exist.
A better option would be to run the calls above once per update vs per update item. That would require a bit more rework though.
Related Issue
Motivation and Context
I was working with long lists and was getting a significant amount of hangs.
This was before the change:
This was after:
How Has This Been Tested
Tested in the airbnb app.
Types of changes
Checklist