Add a README.md file for the thirdparty/ directory
#638
Conversation
|
|
||
| Some downstream changes are yet to be split into separate git diffs; | ||
| after that's done, it will be possible to reapply them using patches | ||
| included in the `patches` folder. |
There was a problem hiding this comment.
There is no "patches" folder and this library changes so rarely that I didn't feel the need to do the effort of making patches. If you want this then perhaps you should add these patches to your commit, or do it in a later commit?
There was a problem hiding this comment.
Yeah, no patches as of right now; I thought about adding something like this as part of the 1.1.1 update in a separate PR.
|
|
||
| Files extracted from upstream source: | ||
|
|
||
| - TODO |
There was a problem hiding this comment.
In this case it's pretty much the whole 0.10.0 release without the NoiseTool and with a SConscript file added to integrate to the Godot build system.
|
|
||
| Files extracted from upstream source: | ||
|
|
||
| - TODO |
There was a problem hiding this comment.
This is only lz4.h and lz4.c, bare minimum.
|
|
||
| Files extracted from upstream source: | ||
|
|
||
| - TODO |
There was a problem hiding this comment.
This is the contents of this folder: https://github.com/zeux/meshoptimizer/tree/master/src
With a custom namespace MESHOPTIMIZER_ZYLANN_NAMESPACE_BEGIN to prevent conflict with Godot's own meshoptimizer when compiling as a module.
There is also a custom change in simplifier.cpp, look for MESHOPTIMIZER_ZYLANN_NEVER_COLLAPSE_BORDERS
|
|
||
| Files extracted from upstream source: | ||
|
|
||
| - `C/FastNoiseLite.h` as `FastNoiseLite.h` |
|
Fuzzer seems to have fallen victim to an OOM error 😬 |
|
It's been like that for months. I don't know how to fix this, Godot is just too big to build with sanitizers on Github Actions, even with a good linker |
This PR introduces a README file to the thirdparty directory, akin to how it's done over in Godot's repository.
The reasoning behind this addition is to ease the process of updating thirdparty libraries.
As of right now, the list is not complete (see all the "TODO"s and "?") - I tried being as thorough as I can, but I am not able to deduce everything in a reasonable time, so I'd like to ask all those responsible for introducing these libraries (possibly all of them can be traced back to Zylann) to come forward and aid me in putting all relevant and accurate information here 😅