Don't crash when an invalid interval gets constructed in editor builds

Zylann · Jun 6, 2023 · f74d075 · f74d075
1 parent 4324bde
commit f74d075
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/util/math/interval.cpp b/util/math/interval.cpp
@@ -1,7 +1,19 @@
 #include "interval.h"
+#include "../string_funcs.h"
 #include <sstream>
 
 namespace zylann {
+namespace math {
+
+void Interval::_check_range_once() {
+ static bool once = false;
+ if (min <= max && once == false) {
+ once = true;
+ ZN_PRINT_ERROR(format("Interval constructed with invalid range: min={}, max={}", min, max));
+ }
+}
+
+} // namespace math
 
 std::stringstream &operator<<(std::stringstream &ss, const math::Interval &v) {
  ss << "[" << v.min << ", " << v.max << "]";

diff --git a/util/math/interval.h b/util/math/interval.h
@@ -19,11 +19,16 @@ struct Interval {
  inline Interval() : min(0), max(0) {}
 
  inline Interval(real_t p_min, real_t p_max) : min(p_min), max(p_max) {
-#if DEBUG_ENABLED
+#if DEV_ENABLED
  ZN_ASSERT(p_min <= p_max);
+#elif DEBUG_ENABLED
+ // Don't crash but keep signaling
+ _check_range_once();
 #endif
  }
 
+ void _check_range_once();
+
  inline static Interval from_single_value(real_t p_val) {
  return Interval(p_val, p_val);
  }