Make VoxelVoxLoader method static

Zylann · Jun 9, 2024 · bb99835 · bb99835
1 parent 2cb6bc7
commit bb99835
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/doc/source/changelog.md b/doc/source/changelog.md
@@ -23,6 +23,9 @@ Semver is not yet in place, so each version can have breaking changes, although
  - Fixed slow loading when the database path contains `res:https://` or `user:https://`
  - `VoxelInstancer`: Fixed instances with LOD > 0 were generated on `VoxelTerrain` even though LOD isn't supported (ending up in weird positions). No instances should generate.
 
+- Breaking changes
+ - `VoxelVoxLoader`: methods are now static, so no instance of the class need to be created
+
 
 1.2 - 20/04/2024 - branch `1.2` - tag `v1.2.0`
 ------------------------------------------------

diff --git a/streams/vox/vox_loader.cpp b/streams/vox/vox_loader.cpp
@@ -80,7 +80,8 @@ int /*Error*/ VoxelVoxLoader::load_from_file(
 }
 
 void VoxelVoxLoader::_bind_methods() {
- ClassDB::bind_method(
+ ClassDB::bind_static_method(
+ VoxelVoxLoader::get_class_static(),
  D_METHOD("load_from_file", "fpath", "voxels", "palette", "dst_channel"),
  &VoxelVoxLoader::load_from_file,
  DEFVAL(godot::VoxelBuffer::CHANNEL_COLOR)

diff --git a/streams/vox/vox_loader.h b/streams/vox/vox_loader.h
@@ -14,7 +14,7 @@ class VoxelVoxLoader : public RefCounted {
 
 public:
  // TODO GDX: Can't bind functions returning a `godot::Error` enum
- int /*Error*/ load_from_file(
+ static int /*Error*/ load_from_file(
  String fpath,
  Ref<godot::VoxelBuffer> p_voxels,
  Ref<VoxelColorPalette> palette,