Fix missing configuration warning on VoxelModifierMesh

Zylann · Jun 13, 2024 · aac7025 · aac7025
1 parent 5882ade
commit aac7025
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/doc/source/changelog.md b/doc/source/changelog.md
@@ -26,7 +26,9 @@ Primarily developped with Godot 4.3.
  - Fixed slow loading when the database path contains `res:https://` or `user:https://`
  - `VoxelInstancer`: Fixed instances with LOD > 0 were generated on `VoxelTerrain` even though LOD isn't supported (ending up in weird positions). No instances should generate.
  - `VoxelMeshSDF`: Fixed error in the editor when trying to visualize the last slice (which turns out to be off by 1)
- - `VoxelModifierMesh`: Fixed setting `isolevel` had no effect
+ - `VoxelModifierMesh`: 
+ - Fixed setting `isolevel` had no effect
+ - Fixed missing configuration warning when parenting under `VoxelTerrain` (only `VoxelLodTerrain` is supported)
 
 - Breaking changes
  - `VoxelVoxLoader`: methods are now static, so no instance of the class need to be created

diff --git a/modifiers/godot/voxel_modifier_mesh_gd.cpp b/modifiers/godot/voxel_modifier_mesh_gd.cpp
@@ -78,6 +78,8 @@ void VoxelModifierMesh::_on_mesh_sdf_baked() {
 #ifdef TOOLS_ENABLED
 
 void VoxelModifierMesh::get_configuration_warnings(PackedStringArray &warnings) const {
+ VoxelModifier::get_configuration_warnings(warnings);
+
  if (_mesh_sdf.is_null()) {
  warnings.append(ZN_TTR("A {0} resource is required for {1} to function.")
  .format(varray(VoxelMeshSDF::get_class_static(), VoxelModifierMesh::get_class_static()))