Fix error when visualizing the last slice of VoxelMeshSDF

doc/source/changelog.md

@@ -25,6 +25,7 @@ Primarily developped with Godot 4.3.
  - Fixed `set_key_cache_enabled(true)` caused nothing to load
  - Fixed slow loading when the database path contains `res:https://` or `user:https://`
  - `VoxelInstancer`: Fixed instances with LOD > 0 were generated on `VoxelTerrain` even though LOD isn't supported (ending up in weird positions). No instances should generate.
+ - `VoxelMeshSDF`: Fixed error in the editor when trying to visualize the last slice (which turns out to be off by 1)
  - `VoxelModifierMesh`: Fixed setting `isolevel` had no effect
 
 - Breaking changes

editor/mesh_sdf/voxel_mesh_sdf_viewer.cpp

@@ -110,10 +110,10 @@ void VoxelMeshSDFViewer::_on_slice_spinbox_value_changed(float value) {
  if (_slice_spinbox_ignored) {
  return;
  }
- int slice_y = value;
+ const int slice_y = value;
  ZN_ASSERT_RETURN(_mesh_sdf.is_valid() && _mesh_sdf->is_baked());
  ZN_ASSERT_RETURN(slice_y >= 0 && slice_y < _mesh_sdf->get_voxel_buffer()->get_size().y);
- _slice_y = value;
+ _slice_y = slice_y;
  update_view();
 }
 
@@ -151,7 +151,7 @@ void VoxelMeshSDFViewer::update_slice_spinbox() {
  _slice_spinbox->set_editable(true);
  _slice_spinbox->set_min(0);
  Ref<godot::VoxelBuffer> vb = _mesh_sdf->get_voxel_buffer();
- _slice_spinbox->set_max(vb->get_size().y);
+ _slice_spinbox->set_max(vb->get_size().y - 1);
  _slice_spinbox->set_step(1);
  _slice_spinbox->set_value(_slice_y);