Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move generic site data into self contained objects. #21368
base: trunk
Are you sure you want to change the base?
Move generic site data into self contained objects. #21368
Changes from 1 commit
b2c48bc
ce19572
36c618e
91196f3
41803e3
0e183c6
b977e05
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 37 in admin/formatter/class-post-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 37 in admin/formatter/class-post-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 38 in admin/formatter/class-post-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 38 in admin/formatter/class-post-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 60 in admin/formatter/class-post-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 60 in admin/formatter/class-post-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 109 in admin/formatter/class-post-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 109 in admin/formatter/class-post-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 127 in admin/formatter/class-post-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 127 in admin/formatter/class-post-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 37 in admin/formatter/class-term-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 37 in admin/formatter/class-term-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 66 in admin/formatter/class-term-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 66 in admin/formatter/class-term-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 104 in admin/formatter/class-term-metabox-formatter.php
GitHub Actions / Check code style
Check failure on line 104 in admin/formatter/class-term-metabox-formatter.php
GitHub Actions / Check code style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's assign the
$repo->get_term_site_information()
result to a variable, so as to not call it twice here and in the line above.Check failure on line 298 in admin/taxonomy/class-taxonomy.php
GitHub Actions / Check code style
Check failure on line 298 in admin/taxonomy/class-taxonomy.php
GitHub Actions / Check code style
Check failure on line 314 in admin/taxonomy/class-taxonomy.php
GitHub Actions / Check code style
Check failure on line 314 in admin/taxonomy/class-taxonomy.php
GitHub Actions / Check code style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we creating a repository that just returns instances of a couple of classes? We could just instantiate them in the metabox classes, without the use of a repository.
Unless I'm missing something...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this because I wanted to follow the same as I did for all the other script data code, and I wanted the entry point for this to be in the application folder and not in the framework folder to more adhere to the Onion way.