Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move generic site data into self contained objects. #21368

Merged
merged 11 commits into from
Jul 1, 2024
Merged

Move generic site data into self contained objects. #21368

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b2c48bc
Move generic site data into self contained objects.
thijsoo May 6, 2024
ce19572
Add legacy non legacy difference.
thijsoo May 7, 2024
36c618e
Update tests.
thijsoo May 7, 2024
91196f3
merge.
thijsoo May 7, 2024
41803e3
Use dynamic links.
thijsoo May 7, 2024
0e183c6
Feedback.
thijsoo May 30, 2024
b977e05
CS.
thijsoo May 30, 2024
10e493a
Merge branch 'feature/plugin-fixes' of github.com:Yoast/wordpress-seo…
igorschoester Jul 1, 2024
d8ef0d8
Fix taxonomy metadata: should use legacy formatting still
igorschoester Jul 1, 2024
dc4e5fa
Move dependencies specific to posts out of the base
igorschoester Jul 1, 2024
7699f46
Fix PHPCS
igorschoester Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use dynamic links.
  • Loading branch information
@thijsoo
thijsoo committed May 7, 2024
commit 41803e3b41e438d98b7896181e77fa0aa9c61e7c
26 changes: 4 additions & 22 deletions tests/WP/Editors/Framework/Site/Post_Site_Information_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,18 +118,9 @@ public function test_legacy_site_information() {
],
'dismissedAlerts' => false,
'currentPromotions' => [],
'webinarIntroBlockEditorUrl' => 'https://yoa.st/webinar-intro-block-editor?php_version=7.4&platform=wordpress&platform_version=6.6-alpha-57778-src&software=free&software_version=22.7-RC3&days_active=14&user_language=en_US',
'webinarIntroBlockEditorUrl' => $this->short_link_helper->get( 'https://yoa.st/webinar-intro-block-editor' ),
'blackFridayBlockEditorUrl' => '',
'linkParams' =>
[
'php_version' => '7.4',
'platform' => 'wordpress',
'platform_version' => '6.6-alpha-57778-src',
'software' => 'free',
'software_version' => '22.7-RC3',
'days_active' => 14,
'user_language' => 'en_US',
],
'linkParams' => $this->short_link_helper->get_query_params(),
'pluginUrl' => 'http:https://example.org/wp-content/plugins/wordpress-seo',
'wistiaEmbedPermission' => true,
];
Expand All @@ -156,18 +147,9 @@ public function test_site_information() {
'base_url' => 'http:https://example.org/',
'dismissedAlerts' => false,
'currentPromotions' => [],
'webinarIntroBlockEditorUrl' => 'https://yoa.st/webinar-intro-block-editor?php_version=7.4&platform=wordpress&platform_version=6.6-alpha-57778-src&software=free&software_version=22.7-RC3&days_active=14&user_language=en_US',
'webinarIntroBlockEditorUrl' => $this->short_link_helper->get( 'https://yoa.st/webinar-intro-block-editor' ),
'blackFridayBlockEditorUrl' => '',
'linkParams' =>
[
'php_version' => '7.4',
'platform' => 'wordpress',
'platform_version' => '6.6-alpha-57778-src',
'software' => 'free',
'software_version' => '22.7-RC3',
'days_active' => 14,
'user_language' => 'en_US',
],
'linkParams' => $this->short_link_helper->get_query_params(),
'pluginUrl' => 'http:https://example.org/wp-content/plugins/wordpress-seo',
'wistiaEmbedPermission' => true,
'site_name' => 'Test Blog',
Expand Down
Loading